Re: CopyReadLineText optimization

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: CopyReadLineText optimization
Date: 2008-03-06 19:29:24
Message-ID: 47D04614.7060109@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> BTW, I notice that the code allows CSV escape and quote characters that
> have the high bit set (in single-byte server encodings that is). Is
> this a good idea? It seems like such are extremely unlikely to be the
> same in two different encodings. Maybe we should restrict to the ASCII
> range? Especially if the client encoding is multibyte ...
>
>
>

In the commonest case these are both either " or '. I would not have any
objection to requiring them to be ASCII chars.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2008-03-06 19:38:36 Re: CopyReadLineText optimization
Previous Message Andrew Dunstan 2008-03-06 19:24:19 Re: CopyReadLineText optimization

Browse pgsql-patches by date

  From Date Subject
Next Message Heikki Linnakangas 2008-03-06 19:38:36 Re: CopyReadLineText optimization
Previous Message Andrew Dunstan 2008-03-06 19:24:19 Re: CopyReadLineText optimization