Re: CopyReadLineText optimization

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: CopyReadLineText optimization
Date: 2008-03-05 17:46:26
Message-ID: 47CEDC72.2050600@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Heikki Linnakangas wrote:
>
>
> So the overhead of using memchr slows us down if there's a lot of
> escape or quote characters. The breakeven point seems to be about 1 in
> 8 characters. I'm not sure if that's a good tradeoff or not...
>
>

How about we test the first buffer read in from the file and change
strategy accordingly?

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Gurjeet Singh 2008-03-05 18:07:46 Re: Patch to update libpqxx's homepage in README
Previous Message Magnus Hagander 2008-03-05 17:36:58 Re: Patch to update libpqxx's homepage in README

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2008-03-05 18:29:46 Re: TransactionIdIsInProgress() cache
Previous Message Bruce Momjian 2008-03-05 17:00:57 Re: Endless recovery