| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, pgsql-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>, Gregory Stark <stark(at)enterprisedb(dot)com>, Csaba Nagy <nagy(at)ecircle-ag(dot)com>, Aidan Van Dyk <aidan(at)highrise(dot)ca> |
| Subject: | Re: Permanent settings |
| Date: | 2008-02-21 03:52:13 |
| Message-ID: | 47BCF56D.80704@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Josh Berkus <josh(at)agliodbs(dot)com> writes:
>
>> The problem I've constantly run into with parsing and modifying settings
>> in a user-edited postgresql.conf file is that sometimes users do their
>> own chronological documentation:
>> [snip]
>>
>
> Yeah, those are good examples. It would be fairly easy to deal with a
> postgresql.conf file that's in a pristine state, but I can see that
> distinguishing "commented-out values" from actual comments is likely
> to be AI-complete :-(
>
>
How about if we provide for a magic value of 'default' for every
setting? So the model config file would move from lines like this:
#port = 5432 # (change requires restart)
to lines like this:
port = default # 5432 (change requires restart)
So we'd never uncomment a commented out line.
That way we could preserve comments, which would be a Good Thing (tm)
Then I think Tom's original proposal suitably modified would make sense.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aidan Van Dyk | 2008-02-21 04:02:34 | Re: Permanent settings |
| Previous Message | Joshua D. Drake | 2008-02-21 02:14:27 | Re: Permanent settings |