Re: Why does pg_ctl.c have its own copy of PM_VERSIONSTR?

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Why does pg_ctl.c have its own copy of PM_VERSIONSTR?
Date: 2008-02-20 21:20:22
Message-ID: 47BC9996.7040602@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Why isn't pg_ctl.c using PG_VERSIONSTR from miscadmin.h? Seems like
> this is something that will have to be kept in sync manually (I see
> from the CVS logs that Peter already had to do that once).
>
> If the feeling is that miscadmin.h is a backend include file that
> shouldn't be used by pg_ctl (which is not totally unreasonable,
> though I think there's no harm in it given the current contents
> of that file), maybe we should move PG_VERSIONSTR someplace else?
>
>
>

Your opinion of my memory at nearly 4 years remove is way too high :-)

I don't even know if that was my doing or Bruce's - probably mine though.

It looks like I adapted it from initdb.c - that would make sense given
the time frames.

There is unlikely to be any deep reason.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dawid Kuroczko 2008-02-20 21:27:26 Re: Permanent settings
Previous Message Tom Lane 2008-02-20 20:57:45 Why does pg_ctl.c have its own copy of PM_VERSIONSTR?