Re: [PATCH] Don't bail with legitimate -N/-B options

From: Andreas Kling <andreas(dot)kling(at)acgnystrom(dot)se>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: [PATCH] Don't bail with legitimate -N/-B options
Date: 2008-02-16 21:14:40
Message-ID: 47B75240.7000504@acgnystrom.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Magnus Hagander wrote:
> Anybody know *why* Gentoo does such a thing? Having shared buffers at
> the very lowest possible boundary just seems counterproductive. Plus,
> the normal way to set these things would be in postgresql.conf, why
> override them on the commandline?
>
> It's not the first time I've seen people complain about this, it'd be
> good to know why.
It's been brought up on the Gentoo bugzilla
(http://bugs.gentoo.org/show_bug.cgi?id=206725), so hopefully something
will come of that.

> Those are not comments on the actual patch, of course. For that one,
> it looks to me like it's the wrong fix. I don't think we should be
> adding to shared buffers like that - if somebody asked for a specific
> value they should get that. But in that case the error message needs
> to be changed, since it's misleading.
If we follow that logic, there shouldn't be an error message at all. ;-)

Cheers,
Andreas

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Magnus Hagander 2008-02-16 21:33:32 Re: [PATCH] Don't bail with legitimate -N/-B options
Previous Message Magnus Hagander 2008-02-16 21:09:10 Re: [PATCH] Don't bail with legitimate -N/-B options