Re: LLVM strip -x fails

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, Palle Girgensohn <girgen(at)pingpong(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: LLVM strip -x fails
Date: 2023-04-21 16:49:04
Message-ID: 478a73ae-ba12-a6dc-99bb-6623161354db@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 21.04.23 18:41, Peter Eisentraut wrote:
> On 20.04.23 17:33, Andres Freund wrote:
>> Peter, it's unlikely given the timeframe, but do you happen to
>> remember why
>> you specified -x when stripping static libs? This seems to be all the
>> way back
>> from
>>
>> commit 563673e15db995b6f531b44be7bb162330ac157a
>> Author: Peter Eisentraut<peter_e(at)gmx(dot)net>
>> Date:   2002-04-10 16:45:25 +0000
>>
>>      Add make install-strip target.
>>
>>
>> Afaict the only safe thing to use when stripping static libs is
>> -g/--strip-debug.
>
> I suspect this was copied from GNU Libtool.  Libtool still has that but
> later changed the stripping of static libraries on darwin to "strip -S".
>  Maybe should adopt that.

Here is the current logic in GNU Libtool:

https://github.com/autotools-mirror/libtool/blob/master/m4/libtool.m4#L2214

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2023-04-21 16:49:40 Re: Commitfest 2023-03 starting tomorrow!
Previous Message Peter Eisentraut 2023-04-21 16:41:54 Re: LLVM strip -x fails