Re: Make pg_dump suppress COMMENT ON SCHEMA public ?

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Make pg_dump suppress COMMENT ON SCHEMA public ?
Date: 2008-01-13 18:09:45
Message-ID: 478A53E9.1020809@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Tom Lane wrote:
>>> We don't dump non-default comments on other system objects either,
>>> so I don't think it's out of line to suppress the one on schema public.
>
>> The distinction then is if "public" is actually a system object.
>
> Yeah, it's a borderline case, which is exactly why we're having trouble
> with it ...
>
> What do you think of Kris' idea of just removing the default comment?

That'll work for new databases, but as you say it will not work for
older once since the comment will just be carried along with them. That
said, removing the default comment might be a good idea anyway, because
it's not like it's actually adding any value...

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannes Dorbath 2008-01-13 18:50:51 Re: Index trouble with 8.3b4
Previous Message Tom Lane 2008-01-13 17:56:57 Re: Make pg_dump suppress COMMENT ON SCHEMA public ?