Re: pgbench enhancements

From: andrew(at)dunslane(dot)net
To: "Tatsuo Ishii" <ishii(at)sraoss(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgbench enhancements
Date: 2006-07-26 15:52:33
Message-ID: 4754.68.143.134.146.1153929153.squirrel@www.dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>> > Hi,
>> >
>> > I have committed contrib/pgbench enhanments contributed by Tomoaki
>> > Sato from SRA OSS, Inc. Japan.
>> >
>> > - predefined variable "tps"
>> > The value of variable tps is taken from the scaling factor
>> > specified by -s option.
>> >
>> > - -D option
>> > Variable values can be defined by -D option.
>> >
>> > - \set command now allows arithmetic calculations.
>> >
>>
>>
>> Was there a previous patch posted for this? I don't recall seeing it.
>
> Are you saying that I should have posted patches and called for
> discussion? I omit the step because a) pgbench is a contrib program,
> b) the changes do not break the backward compatibility.
>
> I always call for discussions for questionable part. (for example,
> column type change proposal for pgbench tables).

It's not a big deal, but I was under the impression that even in these
circumstances a patch should be posted first, especially if it changes
user visible behaviour.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2006-07-26 15:54:31 Re: Refactoring the API for amgetmulti
Previous Message Csaba Nagy 2006-07-26 15:49:25 Re: [HACKERS] Resurrecting per-page cleaner for btree