Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches
Date: 2022-03-31 00:19:41
Message-ID: 474104.1648685981@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Make PostgreSQL::Test::Cluster compatible with all live branches

prairiedog is unhappy [1], seemingly as a result of this patch:

t/001_repl_stats....Can't locate parent.pm in @INC (@INC contains: ../../src/test/perl/ . /usr/local/perl5.8.3/lib/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/5.8.3 /usr/local/perl5.8.3/lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_perl/5.8.3 /usr/local/perl5.8.3/lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_perl/5.8.3 /usr/local/perl5.8.3/lib/site_perl . /usr/local/perl5.8.3/lib/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/5.8.3 /usr/local/perl5.8.3/lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_perl/5.8.3 /usr/local/perl5.8.3/lib/site_perl .) at ../../src/test/perl//PostgreSQL/Test/Cluster.pm line 2921.
BEGIN failed--compilation aborted at ../../src/test/perl//PostgreSQL/Test/Cluster.pm line 2921.

I think this means that its old Perl version misinterprets

use parent -norequire, qw(PostgreSQL::Test::Cluster);

as a request to include "parent.pm". Is there a more
backwards-compatible way to spell that?

regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedog&dt=2022-03-30%2021%3A23%3A58

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2022-03-31 01:01:07 Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches
Previous Message Tom Lane 2022-03-31 00:01:05 Re: pgsql: Add 'basebackup_to_shell' contrib module.