From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: factorial function/phase out postfix operators? |
Date: | 2020-09-11 20:51:50 |
Message-ID: | 474027.1599857510@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> writes:
> On Sep 11, 2020, at 12:54 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Fri, Sep 11, 2020 at 3:23 PM Mark Dilger
>> <mark(dot)dilger(at)enterprisedb(dot)com> wrote:
>>> Another option would be to have pg_dump take a strictness mode option. I don't think the option should have anything to do with postfix operators specifically, but be more general like --dump-incompatible-objects vs. --omit-incompatible-objects vs. --error-on-incompatible-objects vs. --do-your-best-to-fixup-incompatible-objects, with one of those being the default (and with all of them having better names). If --error-on-incompatible-objects were the default, that would behave as Robert recommended upthread.
>>> I can totally see an objection to the added complexity of such options, so I'm really just putting this out on the list for comment.
>> I'm not opposed to Tom's proposal. I just wanted to raise the issue
>> for discussion.
> Ah, ok. I don't feel any need for changes, either. I'll leave the
> patch as it stands now.
We're in violent agreement it seems.
At some point it might be worth doing something like what Mark suggests
above, but this patch shouldn't be tasked with it. In any case, since
pg_dump does not know what the target server version really is, it's
going to be hard for it to authoritatively distinguish what will work
or not.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | James Coleman | 2020-09-11 21:11:34 | Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays |
Previous Message | Tom Lane | 2020-09-11 20:44:25 | Re: Simplified version of read_binary_file (src/backend/utils/adt/genfile.c) |