Re: [PATCH] bms_prev_member() can read beyond the end of the array of allocated words

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Greg Burd <greg(at)burd(dot)me>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] bms_prev_member() can read beyond the end of the array of allocated words
Date: 2025-08-14 19:45:41
Message-ID: 472867.1755200741@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greg Burd <greg(at)burd(dot)me> writes:
> Spoiler alert, I have larger plans[2] for Bitmapset which is why I
> started down this road to begin with as I wanted to capture the existing
> API/contract for it before I proposed changes to it.

FWIW, I'd be seriously resistant to simply replacing Bitmapset with
something like that, as I think the present implementation is about
right for the planner's uses and complicating it would just slow
things down. There may be specific places where a compressed
implementation could win, though.

Anyway, that's off-topic for the present thread. I believe it's
middle-of-the-night in Rowley's time zone, so I was waiting for
further comment from him before taking any action.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2025-08-14 20:12:40 Re: index prefetching
Previous Message Peter Geoghegan 2025-08-14 19:45:26 Re: index prefetching