Re: Skytools committed without hackers discussion/review

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Marko Kreen <markokr(at)gmail(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Michael Glaesemann <grzm(at)seespotcode(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Skytools committed without hackers discussion/review
Date: 2007-10-10 14:48:15
Message-ID: 470CE62F.8040104@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Magnus Hagander wrote:
> If it is this irreplacable killer feature, it should *not* be in contrib.
> It should be in the core backend, and we should be discussing if we can
> bend the rules for that. This is the proper forum for discussing that, so
> let's bring that question to the table.
>
> Our beta-1 is already fairly broken (the locale stuff on our most
> downloaded platform), so perhaps we should pull that one back, put this
> stuff in the backend, and try to get a beta2 out ASAP?
>
>
> Putting it in contrib "just because we were too late to put it in the
> backend, but it is reallyi really important for our users" just doesn't
> make sense.
>
>
>

I agree with most of this. If it's really that important we should
abandon beta1 in effect and open the tree for just this and as much of
the extra tsearch samples as we care to take. But that's a decision that
should be taken openly, after discussion on -hackers. I don't think I'm
being arrogant when I say that if I was completely unaware of this
proposal then a great many other people probably were too.

cheers

andrew

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2007-10-10 14:57:42 Re: [COMMITTERS] pgsql: Added the Skytools extended transaction ID module to contrib as
Previous Message Bruce Momjian 2007-10-10 14:42:53 Re: Skytools committed without hackers discussion/review

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-10-10 14:55:01 Re: Locale + encoding combinations
Previous Message Bruce Momjian 2007-10-10 14:44:38 Re: some points for FAQ