Re: [PATCH] Keeps tracking the uniqueness with UniqueKey

From: Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Floris Van Nee <florisvannee(at)optiver(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "rushabh(dot)lathia(at)gmail(dot)com" <rushabh(dot)lathia(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Subject: Re: [PATCH] Keeps tracking the uniqueness with UniqueKey
Date: 2020-11-30 14:30:19
Message-ID: 4704b742-dff2-0104-4fdf-d2058670fff0@redhat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 11/30/20 5:04 AM, Heikki Linnakangas wrote:
> On 26/11/2020 16:58, Andy Fan wrote:
>> This patch has stopped moving for a while,  any suggestion about
>> how to move on is appreciated.
>
> The question on whether UniqueKey.exprs should be a list of
> EquivalenceClasses or PathKeys is unresolved. I don't have an opinion
> on that, but I'd suggest that you pick one or the other and just go
> with it. If it turns out to be a bad choice, then we'll change it.

In this case I think it is matter of deciding if we are going to use
EquivalenceClasses or Exprs before going further; there has been work
ongoing in this area for a while, so having a clear direction from a
committer would be greatly appreciated.

Deciding would also help potential reviewers to give more feedback on
the features implemented on top of the base.

Should there be a new thread with the minimum requirements in order to
get closer ?

Best regards,
 Jesper

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-11-30 14:37:38 Re: Printing LSN made easy
Previous Message Stephen Frost 2020-11-30 14:27:12 Re: Online verification of checksums