Re: OpenSSL Applink

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dave Page <dpage(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: OpenSSL Applink
Date: 2007-10-01 20:34:24
Message-ID: 470159D0.8090403@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Mon, Oct 01, 2007 at 10:51:01AM -0400, Tom Lane wrote:
>>> I'd vote for backpatching, but only as far as 8.2, seeing that we're
>>> abandoning the older branches on Windows.
>
>> Should we backpatch a version of it to previous versions that does just the
>> error stack manipulation, or just ignore on the grounds that nobody has
>> reported the problem there (it's there, but it's a lot more narrow - I know
>> it's there, but I havent' been able to provoket it due to not knowing
>> enough about setting up certificate chains and such)
>
> That's only a cosmetic problem (wrong error message), right? I'd vote
> for no backpatch, at least for now --- I'd rather see this change get
> through beta testing first. Anytime you're fooling with interactions
> with some other package, the risk of portability issues is high.

Right.
Applied to HEAD. Will wait for a buildfarm cycle to make sure it doesn't
kill anything else then try to backport to 8.2 (patch didn't apply
cleanly to it)

//Magnus

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Hiroshi Saito 2007-10-02 05:20:16 Loose check was corrected of win32.mak.
Previous Message Brendan Jurd 2007-10-01 19:20:12 Re: [HACKERS] Text <-> C string