Re: POC: make mxidoff 64 bits

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Maxim Orlov <orlovmg(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: wenhui qiu <qiuwenhuifx(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: POC: make mxidoff 64 bits
Date: 2025-11-17 16:35:46
Message-ID: 46cc45e9-fddd-44bc-bcb3-96889aafd921@iki.fi
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here's yet another patch version. I spent the day reviewing this in
detail and doing little cleanups here and there. I squashed the commits
and wrote a proper commit message.

One noteworthy refactoring is in pg_upgrade.c, to make it more clear (to
me at least) how upgrade from version 9.2 and below now works. It was
actually broken when I tested it. Not sure if I had broken it earlier or
if it never worked, but in any case it works now.

I also tested upgrading a cluster from an old minor version, < 9.3.5,
where the control file has a bogus oldestMultiXid==1 value (see commit
b6a3444fa6). As expected, you get a "could not open file" error:

> Performing Upgrade
> ------------------
> Setting locale and encoding for new cluster ok
> ...
> Deleting files from new pg_multixact/members ok
> Deleting files from new pg_multixact/offsets ok
> Converting pg_multixact files
> could not open file "/home/heikki/pgsql.93stable/data/pg_multixact/offsets/0000": No such file or directory
> Failure, exiting

I don't think we need to support that case. I hope there are no clusters
in that state still in the wild, and you can work around it by upgrading
to 9.3.5 or above and letting autovacuum run. But I wonder if a
pre-upgrade check with a better error message would still be worthwhile.

Ashutosh, you were interested in reviewing this earlier. Would you have
a chance to review this now, before I commit it? Alexander, Alvaro,
would you have a chance to take a final look too, please?

- Heikki

Attachment Content-Type Size
v27-0001-FIXME-bump-catversion.patch text/x-patch 858 bytes
v27-0002-Move-pg_multixact-SLRU-page-format-definitions-t.patch text/x-patch 10.7 KB
v27-0003-Widen-MultiXactOffset-to-64-bits.patch text/x-patch 94.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-11-17 16:44:43 Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions
Previous Message Nazir Bilal Yavuz 2025-11-17 15:45:30 Re: make -C src/test/isolation failure in index-killtuples due to btree_gist