| From: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)postgresql(dot)org> |
| Cc: | pgadmin-hackers(at)postgresql(dot)org, Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
| Subject: | Re: A bunch of minor issues |
| Date: | 2007-09-26 19:37:38 |
| Message-ID: | 46FAB502.2020502@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Dave Page wrote:
> Heikki Linnakangas wrote:
>> There's some strings in calls to wxLogDebug, like "OnTargetComplete()
>> called", that are wrapped in _() for translation. Aren't those just for
>> developers, and therefore a waste of time to translate?
>
> Yep. Removed.
Here's a few more, though I must admit that translating "Someone created
a new line ending style! Run, run for your lives!!" would be much more
fun than the run-of-the-mill strings ;-).
I also added a XXX-comment to a suspicious piece of code in
sysLogger.cpp. It's comparing to a string that's marked for translation,
that's apparently coming from the operating system. You might want to
change it to a non-translated string or something.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| pgadmin-no-debug-translations-1.patch | text/x-diff | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2007-09-26 21:54:36 | Viewing data of a zero-column table gives an assertion failure |
| Previous Message | Dave Page | 2007-09-26 18:08:39 | Re: Patch to add typmod's functions to a type's creation statement |