From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Bytea as C string in pg_convert? |
Date: | 2007-09-24 16:01:47 |
Message-ID: | 46F7DF6B.6040406@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> I have changed it. The thing is, though, that this function not only
>> performs the convert() function but acts as the engine for convert_to()
>> and convert_from(). Those functions do some silent transformations, in
>> one case passing a text Datum as the first argument and in the other
>> case the returning the result as text. If there's a better way to do
>> this I'll be happy to learn, but it seems to me it would involve some
>> duplication - I tried to avoid that where possible.
>>
>
> Hmm. One suggestion would be to have an internal function declared
> as taking and returning "struct varlena *", with a comment saying that
> we depend on text and bytea both being compatible with this. All three
> SQL-visible functions are then thin wrappers around that.
>
>
>
Doesn't strike me as much of an advance, to be honest.
My current top priority is fixing the MSVC build .bat files like Magnus
wants, which will take a bit of time.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-09-24 16:12:25 | Re: Bytea as C string in pg_convert? |
Previous Message | Tom Lane | 2007-09-24 15:45:20 | Re: Reducing NUMERIC size for 8.3 |