Re: [PATCHES] msvc, build and install with cygwin in the PATH

From: Hannes Eder <Hannes(at)HannesEder(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] msvc, build and install with cygwin in the PATH
Date: 2007-09-23 19:46:26
Message-ID: 46F6C292.4030108@HannesEder.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Magnus Hagander schrieb:
> Tom Lane wrote:
>
>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>
>>> Andrew Dunstan wrote:
>>>
>>>> I have committed a fix that is somewhat similar to this. The Install.pm
>>>> module needs some love, but that will have to wait till the next cycle.
>>>>
>>> Thanks, Andrew!
>>>
>> Guys, would you comment on whether this patch closes all the open issues
>> that Bruce has listed for the MSVC port on his "pending patches" page?
>> Specifically, the half-dozen messages with "MSVC" in their subjects at
>> http://momjian.us/cgi-bin/pgpatches
>>
>
> It should, but it'd be good if Hannes can confirm that.
>
>
I found two issues:

(a) use the current dir "." instead of "../.." for the *.sample files,
since there are the chdir's to ../../.. resp. to ../../../.. in line 28
resp. 29. Using ../.. would traverse a too large part of the directory
structure.

(b) a <http://www.dict.cc/englisch-deutsch/superfluous.html>superfluous
\ for the "Dictionaries sample files"

see attached diff.

besides from that it works well in my configuration and it solves the
intial issue with cygwin's dir in PATH. Thank you.

-Hannes

Attachment Content-Type Size
Install.pm-200709231.diff text/x-diff 1.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2007-09-23 20:33:28 Re: [PATCHES] msvc, build and install with cygwin in the PATH
Previous Message Gregory Stark 2007-09-23 19:36:29 Re: [PATCHES] Eliminate more detoast copies for packed varlenas

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2007-09-23 20:33:28 Re: [PATCHES] msvc, build and install with cygwin in the PATH
Previous Message Gregory Stark 2007-09-23 19:36:29 Re: [PATCHES] Eliminate more detoast copies for packed varlenas