Re: Yet more tsearch refactoring

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Yet more tsearch refactoring
Date: 2007-09-10 20:54:54
Message-ID: 46E5AF1E.3090301@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Heikki Linnakangas wrote:
> * Defined new struct WordEntryPosVector that holds a uint16 length and a
> variable size array of WordEntries. This replaces the previous
> convention of a variable size uint16 array, with the first element
> implying the length. WordEntryPosVector has the same layout in memory,
> but is more readable in source code. The POSDATAPTR and POSDATALEN
> macros are still used, though it would now be more readable to access
> the fields in WordEntryPosVector directly.

Did you check it on 64-bit boxes with strict alignment? I remember that was a
headache for me.

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Heikki Linnakangas 2007-09-10 21:59:44 Re: Yet more tsearch refactoring
Previous Message Gregory Stark 2007-09-10 20:22:52 Re: HOT patch - version 15