Re: [HACKERS] pg_regress config

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] pg_regress config
Date: 2007-09-06 17:59:58
Message-ID: 46E0401E.40306@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan wrote:
>
>
> Magnus Hagander wrote:
>> Andrew Dunstan wrote:
>>
>>> I would like to add an argument to pg_regress that allows us to set some
>>> config options for the temp install. Specifically right now I am
>>> interested in setting the following:
>>>
>>> log_line_prefix = '[%c] '
>>> log_statement = 'all'
>>> log_connections = 'true'
>>>
>>> But I think it makes more sense to provide for a general option setting
>>> mechanism, such as --extra_config=/path/to/some/file
>>>
>>> This would dovetail neatly with the recent suggestion that we might
>>> provide for buildfarm members to run several config sets.
>>>
>>> Thoughts?
>>>
>>
>> I think the file makes a lot more sense - would keep you from ending up
>> with really horrible commandlines. Also, it would make it easier if you
>> want to set up different configs manually (the buildfarm script can
>> always manage).
>>
>
> OK, patch attached. I called the option 'temp-config' to go with
> 'temp-install'.

I'd have used an include statement instead of copying the whole file,
but can't see anything actually wrong with it ;-)

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kenneth Marshall 2007-09-06 18:08:59 Re: Hash index todo list item
Previous Message apoc9009 2007-09-06 17:33:01 Re: [FEATURE REQUEST] Streaming Onlinebackup (Maybe OFFTOPIC)

Browse pgsql-patches by date

  From Date Subject
Next Message Heikki Linnakangas 2007-09-06 18:05:57 Re: HOT patch - version 15
Previous Message Simon Riggs 2007-09-06 17:59:41 Re: HOT patch - version 15