From: | "Hamid Quddus Akhtar" <hamid(dot)akhtar(at)enterprisedb(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Crash with empty dictionary |
Date: | 2007-08-22 13:21:20 |
Message-ID: | 46CC3850.3090202@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> Heikki Linnakangas <heikki(at)enterprisedb(dot)com> writes:
>
>> I'm not sure if this is a sane way to set up a dictionary, but surely
>> seg faulting is not the right thing to do. Should we throw an error on
>> an empty dict file, or should we swallow it without crashing?
>>
>
> Offhand I'd say that an empty file is a legitimate corner case,
> so we should just take it silently.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: You can help support the PostgreSQL project by donating at
>
> http://www.postgresql.org/about/donate
>
>
>
Shouldn't we be warning about an empty file rather than just swallowing
up the error? It might not be intentional and rather than the user
trying to figure it out, we should at least be informing him/her...
--
Hamid
From | Date | Subject | |
---|---|---|---|
Next Message | Martijn van Oosterhout | 2007-08-22 13:33:02 | Re: PG Seg Faults Performing a Query |
Previous Message | Bill Thoen | 2007-08-22 13:09:22 | Re: PG Seg Faults Performing a Query |