| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] COPYable logs |
| Date: | 2007-08-20 01:41:44 |
| Message-ID: | 46C8F158.70403@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> If these prove difficult, I'd say 24K would put us in an equivalent
>> position (two extra copies of the error message plus change). Even so,
>> I'm inclined to say that 8K is very tight.
>>
>
> We really only care about being able to deliver an "out of memory during
> error recovery" message within that space. So yes, you can assume the
> message text isn't huge and there isn't any add-on context info to worry
> about. But there could be localization and/or encoding translation costs.
>
>
>
Well, the attached small patch should reduce the memory impact
substantially. Not sure whether you think that's sufficient, or you want
to take it further.
cheers
andrew
| Attachment | Content-Type | Size |
|---|---|---|
| csvmemory.patch | text/x-patch | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2007-08-20 08:53:12 | pgsql: Add configure option --with-system-tzdata to use operating system |
| Previous Message | Andrew Dunstan | 2007-08-19 21:50:05 | Re: INSERT/SELECT and excessive foreign key checks |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavan Deolasee | 2007-08-20 05:27:55 | HOT patch - version 14 |
| Previous Message | Tom Lane | 2007-08-19 16:58:44 | Re: [PATCHES] COPYable logs |