Re: Bug in ResolveOneParam()

From: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
To: Rainer Bauer <usenet(at)munnin(dot)com>
Cc: pgsql-odbc(at)postgresql(dot)org
Subject: Re: Bug in ResolveOneParam()
Date: 2007-07-17 21:34:47
Message-ID: 469D35F7.6060305@tpf.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-odbc

Rainer Bauer wrote:
> Hello,
>
> I finally was able to track down the bug that occasionally happened when
> UseServerSidePrepare was enabled: the driver is writing past allocated memory.

> The bug is in ResolveOneParam(). At one point this function writes directly
> into the allocated buffer <qb->query_statement> _without_ checking the
> allocated size by calling enlarge_query_statement().
>
> I have added the ENLARGE_NEWSTATEMENT() call which should take care of this
> bug (see attached patch).

Sorry for the delay.
I would take care of it.

Thanks.

Hiroshi Inoue

> Rainer
>
> Index: convert.c
> ===================================================================
> RCS file: /cvsroot/psqlodbc/psqlodbc/convert.c,v
> retrieving revision 1.161
> diff -u -r1.161 convert.c
> --- convert.c 4 Jun 2007 10:24:49 -0000 1.161
> +++ convert.c 16 Jul 2007 09:52:51 -0000
> @@ -3459,6 +3472,7 @@
> } */
> if (req_bind)
> {
> + ENLARGE_NEWSTATEMENT( qb, (qb->npos+4) );
> npos = qb->npos;
> qb->npos += 4;
> }

In response to

Browse pgsql-odbc by date

  From Date Subject
Next Message Sailesh Krishnamurthy 2007-07-18 18:06:14 Build problems with MS VC++ Express 2005
Previous Message Joshua D. Drake 2007-07-17 18:56:15 Re: New Win32 ODBCng for PostgreSQL released