Re: write_pipe_chunks patch messes up early error message output

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: write_pipe_chunks patch messes up early error message output
Date: 2007-07-17 15:55:17
Message-ID: 469CE665.4000907@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> Tom Lane wrote:
>>
>>> Yeah, that would work. You'd have to get rid of the current ad-hoc
>>> method by which it is propagated to the syslogger child process
>>> (EXEC_BACKEND case), because now it will have to be propagated to all
>>> children; so postmaster.c should handle it in BackendParameters.
>>>
>
>
>> The problem with this as it stands is that the syslogger itself is
>> forked before the redirection is done.
>>
>
> Which is entirely correct. Re-read what I said about first launch vs
> relaunch of the syslogger. Its stderr will be connected differently in
> the two cases, and should be handled differently --- we want the first
> launch to try to report problems on its own stderr, but there's no point
> after a relaunch. That's why we pass down redirection_done to it.
>
>
>

What I was trying to nut out was how to handle logging from the first
launched syslogger after redirection is done.

Or, looking at it another way, why would we ever want the syslogger to
use the chunking protocol at all?

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zdenek Kotala 2007-07-17 15:56:08 Re: compiler warnings on the buildfarm
Previous Message Tom Lane 2007-07-17 15:45:56 Re: compiler warnings on the buildfarm