From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: write_pipe_chunks patch messes up early error message output |
Date: | 2007-07-16 14:21:26 |
Message-ID: | 469B7EE6.5040905@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
>
> I think offhand that the correct semantics of the flag are "we have
> redirected our original stderr into a pipe for syslogger", and in
> fact that we should transition the output format exactly at the
> instant where we do that; the starting of the child process happens
> at a slightly different time, and restarting of the child (if needed)
> is yet a different issue.
>
>
>
We could expose syslogger's redirection_done flag, which I think has the
semantics you want. AFAICS it is never unset once set. (I should note
that the distance between the point where this is set and where
SysLoggerPID is set on return from SysLogger_Start is negligible, and no
logging statements are called there, but I take your point about
continuing to use chunking during a syslogger restart when SysLoggerPID
might be 0.)
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2007-07-16 14:23:02 | Dealing with dangling index pointers |
Previous Message | Zeugswetter Andreas ADI SD | 2007-07-16 13:53:06 | Re: write_pipe_chunks patch messes up early error message output |