Re: compiler warnings on the buildfarm

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Kris Jurka <books(at)ejurka(dot)com>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Gorm(dot)Andersen(at)Sun(dot)COM
Subject: Re: compiler warnings on the buildfarm
Date: 2007-07-13 13:58:17
Message-ID: 469784F9.50400@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Heikki Linnakangas <heikki(at)enterprisedb(dot)com> writes:
>> Zdenek Kotala wrote:
>>> I don't see any "const" keyword there.
>
>> Right after that:
>
>>> where int conv(int num_msg, const struct pam_message **msg, struct pam_response **resp, void *appdata_ptr);
>
>> How confusing...
>
> And the pam_start page he cited earlier has a different set of typos in
> its version of the struct :-(. Still, that's two out of three places
> that say it's const, and Solaris appears to be the only implementation
> that has chosen to read it as not const.

Yes, Agree. I try to send request to security team for explanation.
Maybe original author also overlooked it as me today :-).

Zdenek

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-07-13 14:24:50 Re: has anyone looked at burstsort ?
Previous Message Tom Lane 2007-07-13 13:52:10 Re: compiler warnings on the buildfarm