Re: compiler warnings on the buildfarm

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: compiler warnings on the buildfarm
Date: 2007-07-12 23:03:11
Message-ID: 4696B32F.2090308@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
>> animal: eel warnings: 4
>> dirmod.c:206: warning: no previous prototype for 'pgsymlink'
>>
>
> Somebody needs to figure out whether we are supposed to be using
> pgsymlink on Cygwin.
>

According to port.h:

* Cygwin has its own symlinks which work on Win95/98/ME where
* junction points don't, so use it instead. We have no way of
* knowing what type of system Cygwin binaries will be run on.

So it looks like we should not be using pgsymlink() on Cygwin, unless we
declare that these platforms under Cygwin are no longer supported.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-07-12 23:06:30 Re: compiler warnings on the buildfarm
Previous Message Heikki Linnakangas 2007-07-12 22:50:45 Re: compiler warnings on the buildfarm