| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Arseny Sher <a(dot)sher(at)postgrespro(dot)ru> |
| Subject: | Re: Parallel query hangs after a smart shutdown is issued |
| Date: | 2020-08-13 16:45:08 |
| Message-ID: | 469199.1597337108@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Hmmm ... maybe that should be more like
> if (smartShutState != SMART_NORMAL_USAGE &&
> backend_type == BACKEND_TYPE_NORMAL)
After some more rethinking and testing, here's a v5 that feels
fairly final to me. I realized that the logic in canAcceptConnections
was kind of backwards: it's better to check the main pmState restrictions
first and then the smart-shutdown restrictions afterwards.
I'm assuming we want to back-patch this as far as 9.6, where parallel
query began to be a thing.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| keep-bg-processes-alive-in-smart-shutdown-5.patch | text/x-diff | 17.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-08-13 16:50:16 | Re: run pgindent on a regular basis / scripted manner |
| Previous Message | Stephen Frost | 2020-08-13 16:30:44 | Re: run pgindent on a regular basis / scripted manner |