Re: pgsql: Fix confusion in SP-GiST between attribute type and leaf storage

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix confusion in SP-GiST between attribute type and leaf storage
Date: 2021-04-05 02:41:15
Message-ID: 468278.1617590475@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Sun, Apr 04, 2021 at 06:29:09PM +0000, Tom Lane wrote:
>> Fix confusion in SP-GiST between attribute type and leaf storage type.

> anole, woodstar and some other animals have been failing after this
> commit:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2021-04-04%2021%3A36%3A54

Yeah, I believe that's fixed. All the big-endian animals were unhappy,
because they noticed a datatype mismatch in a way that little-endians
did not. (Basically, interpreting a fixed-width box value as varlena
yields a data value length that accidentally works okay on little-endian,
but on big-endian it looks like a huge width and you soon go OOM.)

I was able to reproduce it locally on a spare PPC Mac, so I'm
pretty confident that dfc843d fixes it. Takes a while for these
old dinosaurs to report in, though.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2021-04-05 07:17:14 pgsql: Renumber cursor option flags
Previous Message Michael Paquier 2021-04-05 02:27:39 Re: pgsql: Fix confusion in SP-GiST between attribute type and leaf storage