Re: tsearch_core patch: permissions and security issues

From: Michael Paesold <mpaesold(at)gmx(dot)at>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Gregory Stark <stark(at)enterprisedb(dot)com>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: tsearch_core patch: permissions and security issues
Date: 2007-06-14 19:52:42
Message-ID: 46719C8A.4080104@gmx.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-advocacy pgsql-hackers

Bruce Momjian wrote:
> I an attempt to communicate what full text search does, and what
> features we are thinking of adding/removing, I have put up the
> introduction in HTML:
>
> http://momjian.us/expire/fulltext/HTML/fulltext-intro.html
>

Very good idea, Bruce!

After reading the discussion and the introduction, here is what I think
tsearch in core should at least accomplish in 8.3. Please bear in mind,
that (a) I am talking from a user perspective (there might be technical
arguments against my thoughts) and (b) I have no hands-on experience
with Tsearch2 yet, so more experienced users might have different needs.

- Basic full text search usable for non-superusers
- Out-of-the-box working configuration for as many languages as
reasonable (Teodor named quite a number of languages working as-is,
so this is really an improvement over contrib, great!)
- No foot-guns accessible to non-superuser
- Agreement on function names, perhaps some should be changed. For
instance to_tsquery() and plainto_tsquery() seem rather unintuitive
because they don't have a common prefix, and they are not consistent
about using underscores. Perhaps to_tsquery() and to_tsquery_plain()?
- Future compatibility for all features available to non-superusers
- Stop words in tables, not in external files.
- At least for superusers, all features available in contrib now,
should be available, too (don't know about pg_dump).

What I don't really like is the number of commands introduced without
any strong reference to full text search. E.g. CREATE CONFIGURATION
gives no hint at all that this is about full text search. IMHO there are
more configurations than just full text ones. :-) So perhaps better
spell this CREATE FULLTEXT CONFIGURATION etc.? (Think about tab
completion in psql, for instance.)

I guess this is in line with what Tom said about mapping objects and
CREATE ATTRIBUTE vs. CREATE/ALTER CONFIGURATION.
(http://archives.postgresql.org/pgsql-hackers/2007-06/msg00522.php)

After all, I would really welcome having full text search capabilities
in core.

Best Regards
Michael Paesold

In response to

Responses

Browse pgsql-advocacy by date

  From Date Subject
Next Message Tom Lane 2007-06-14 19:56:47 Re: tsearch_core patch: permissions and security issues
Previous Message Tom Lane 2007-06-14 19:49:21 Re: tsearch_core patch: permissions and security issues

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-06-14 19:56:47 Re: tsearch_core patch: permissions and security issues
Previous Message Tom Lane 2007-06-14 19:49:21 Re: tsearch_core patch: permissions and security issues