Re: pipe chunks protocol

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To:
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pipe chunks protocol
Date: 2007-06-13 15:53:03
Message-ID: 467012DF.6060108@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


and here's the patch

Andrew Dunstan wrote:
>
> This patch implements the protocol Tom suggested for writing to the
> syslogger pipe. It seems to pass my tests (basically "make
> installcheck" against a server with stderr redirection turned on and
> log_statement set to 'all').
>
> The effect of this should be to prevent two problems:
> . partial messages get written to the log file, which messes with
> rotation, and
> . messages from various backends get interleaved, causing garbled logs.
>
> Please review ASAP. I want to get this applied soon so that a) it gets
> wider testing and b) I can use it as the basis for the adapted CSV log
> patch. If this is acceptable I intend to backpatch this all the way to
> wherever we started using the syslogger pipe (was that 8.0?).
>
> cheers
>
> andrew
>
>

Attachment Content-Type Size
logpipe.patch text/x-patch 14.1 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2007-06-13 17:29:11 Re: [PATCHES] Autovacuum launcher doesn't notice death of postmaster immediately
Previous Message Andrew Dunstan 2007-06-13 15:51:46 pipe chunks protocol