Re: XLogWrite uses palloc within a critical section

On 25/05/18 07:45, Kyotaro HORIGUCHI wrote:
> Hello.
>
> I happened to see the following in XLogWrite.
>
>> ereport(PANIC,
>> (errcode_for_file_access(),
>> errmsg("could not seek in log file %s to offset %u: %m",
>> XLogFileNameP(ThisTimeLineID, openLogSegNo),
>> startoffset)));
>
> where XLogFileNameP calls palloc within, and it is within a
> critical section there. So it ends with assertion failure hiding
> the PANIC message. We should use XLogFileName instead. The
> problem has existed at least since 9.3. The code is frequently
> revised so the patch needed to vary into four files.

Hmm, that's rather annoying, it sure would be handy if we could do small
palloc()s like this in error messages safely.

I wonder if we could switch to ErrorContext in errstart()? That way, any
small allocations in the ereport() arguments, like what XLogFileNameP()
does, would be allocated in ErrorContext.

- Heikki