| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: WIP csv logs |
| Date: | 2007-06-06 21:13:04 |
| Message-ID: | 46672360.2050007@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Alvaro Herrera wrote:
> Andrew Dunstan wrote:
>
>> Attached is my WIP version of the CSV logs patch. It does not include
>> docs changes.
>>
>> It fixes the CSV thinko I just posted about, and also implements the
>> "safe to rotate" scheme I suggested yesterday, at quite a modest cost.
>> As Tom rightly points out, that does not protect us against interleaving
>> log lines from different backends, which is an open problem.
>>
>
> I wonder, if we were to use an LWLock to protect writing to the stderr
> pipe, would it be too contentious?
>
>
That was the first thing I wanted to try. I'll code it up and then
people can test to see if we get a significant performance hit.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-06-06 23:26:32 | Re: WIP csv logs |
| Previous Message | Alvaro Herrera | 2007-06-06 20:13:12 | Re: WIP csv logs |