Silence compiler warnings with Python 3.9

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Silence compiler warnings with Python 3.9
Date: 2020-03-02 13:22:01
Message-ID: 465ed5ac-9b08-53e9-3654-7d057ee1e468@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Starting with Python 3.9, the Python headers contain inline functions
that fall afoul of our -Wdeclaration-after-statement coding style. In
order to silence those warnings, I've added some GCC-specific
contortions to disable that warning for Python.h only. Clang doesn't
appear to warn about this at all; maybe it recognizes that this is an
external header file. We could also write a configure check for this if
we want to be more flexible.

(Attempts to convince upstream to change the coding style were
unsuccessful (https://bugs.python.org/issue39615).)

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Silence-compiler-warnings-with-Python-3.9.patch text/plain 1.7 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2020-03-02 13:33:04 Re: Psql patch to show access methods info
Previous Message Fujii Masao 2020-03-02 13:07:14 Re: Minor issues in .pgpass