| From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
|---|---|
| To: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: [pgsql-patches] Ctid chain following enhancement |
| Date: | 2007-05-30 13:43:58 |
| Message-ID: | 465D7F9E.8040702@sun.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Pavan Deolasee napsal(a):
>
> On 5/29/07, *Zdenek Kotala* <Zdenek(dot)Kotala(at)sun(dot)com
> <mailto:Zdenek(dot)Kotala(at)sun(dot)com>> wrote:
>
>
> I'm looking on your patch. I have one comment:
>
> If you have old tid and new tid you can easy compare if new tid points
> to different page? And if page is still same there is no reason to
> Unlock it and lock again. I think add inner loop something like:
>
>
> Tom has already expressed his unwillingness to add complexity
> without any proven benefits. Your suggestion though good would
> make the code more unreadable without much benefit since the
> function is not called very often.
OK. I think Bruce can remove your patch from pipeline?
Zdenek
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2007-05-30 17:41:50 | Re: On patching without write access to CVS |
| Previous Message | Magnus Hagander | 2007-05-30 13:27:40 | Re: msvc, build and install with cygwin in the PATH |