Re: like/ilike improvements

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: andrew(at)supernews(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: like/ilike improvements
Date: 2007-05-25 01:56:58
Message-ID: 4656426A.7000304@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> However, I have just about convinced myself that we don't need
>> IsFirstByte for matching "_" for UTF8, either preceded by "%" or not, as
>> it should always be true. Can anyone come up with a counter example?
>>
>
> You have to be on a first byte before you can meaningfully apply
> NextChar, and you have to use NextChar or else you don't count
> characters correctly (eg "__" must match 2 chars not 2 bytes).
>
>
>

Yes, I agree completely. However it looks to me like IsFirstByte will in
fact always be true when we get to call NextChar for matching "_" for UTF8.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-05-25 02:03:42 Re: like/ilike improvements
Previous Message Tom Lane 2007-05-25 01:26:19 Re: like/ilike improvements

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-05-25 02:03:42 Re: like/ilike improvements
Previous Message Tom Lane 2007-05-25 01:26:19 Re: like/ilike improvements