Re: First version of multi-key index support for GiST

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: First version of multi-key index support for GiST
Date: 2001-05-30 20:35:23
Message-ID: 4655.991254923@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Oleg Bartunov <oleg(at)sai(dot)msu(dot)su> writes:
> We have implemented multi-key index support for GiST. Patch is available
> from http://www.sai.msu.su/~megera/postgres/gist/code/7.1.2/patch_multikeygist.7.1.2.gz

What is the point of the macro

#define ATTGET(itup, Rel, i, isnull ) ((char*)( \
( IndexTupleSize(itup) == sizeof(IndexTupleData) ) ? \
*(isnull)=true, NULL \
: \
index_getattr(itup, i, (Rel)->rd_att, isnull) \
))

It appears to me that index_getattr should handle an all-NULL index
tuple just fine by itself --- certainly the btree code expects it to.
So I do not see the reason for this extra layer on top of it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2001-05-30 20:52:03 Re: [HACKERS] #ifdef OLD_FILE_NAMING
Previous Message Bruce Momjian 2001-05-30 20:16:24 Re: AW: AW: Plans for solving the VACUUM problem