| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier |
| Date: | 2026-02-13 05:46:55 |
| Message-ID: | 4653b0bf-5642-44f1-b059-7cc1db861da7@proxel.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/12/26 5:17 PM, Tom Lane wrote:
> As for SysCacheIdentifier, the root of the problem is that
> SearchSysCache and friends are declared to take "int cacheId"
> not "enum SysCacheIdentifier cacheId". Likely we should change
> that in HEAD, but that'd be an actual not theoretical ABI break
> (the enum's not necessarily int-width). In the back branches
> I'm thinking about adding a dummy function just for this purpose,
> more or less as in the under-commented patch attached.
>
> Thoughts?
Attached a patch which changes that in HEAD and I think for HEAD the
best solution is the just fix all cases where we use ints like this to
actually use the enum.
As for back branches I agree with Michael, just add a comment explaining
why this dummy function is necessary.
Andreas
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Use-SysCacheIdentifier-enum-instead-of-int.patch | text/x-patch | 9.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Karlsson | 2026-02-13 05:56:00 | Re: Incremental View Maintenance, take 2 |
| Previous Message | Peter Smith | 2026-02-13 05:42:35 | Re: [PATCH] Support automatic sequence replication |