From: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Chris Browne <cbbrowne(at)acm(dot)org>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: [DOCS] Autovacuum and XID wraparound |
Date: | 2007-05-16 13:59:54 |
Message-ID: | 464B0E5A.1070807@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs pgsql-patches |
Alvaro Herrera wrote:
> However, given that Heikki just confirmed that CLUSTER does not freeze
> tuples, it's not really possible to do this, so I'll drop the CLUSTER
> patch for now.
>
> This means that people using CLUSTER to compact tables won't have the
> benefit of advancing relfrozenxid, so they will have to run VACUUM on
> those tables at some point anyway, even though there will be no dead
> tuples :-(
Now that I think this a bit more, I think CLUSTER should freeze the
tuples. I was worried about losing valuable debug information by doing
that, but thinking a bit more that's not a big concern: we wouldn't
freeze tuples newer than recent xmin. The update chain logic is the most
risky part of the code, and we wouldn't lose the xmin and xmax of tuples
that are part of update chains.
Patch attached. You'll need the changes to cluster.c to set the
relfrozenid as well.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
cluster-freeze.patch | text/x-diff | 716 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | David Fetter | 2007-05-16 14:15:49 | Re: [PATCHES] OS/X startup scripts |
Previous Message | Alvaro Herrera | 2007-05-16 12:44:20 | Re: [DOCS] Autovacuum and XID wraparound |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2007-05-16 14:14:14 | Re: actualised forgotten Magnus's patch for plpgsql MOVE statement |
Previous Message | Gregory Stark | 2007-05-16 13:39:24 | Re: updated SORT/LIMIT patch |