BufFileWrite across MAX_PHYSICAL_FILESIZE boundary

From: "Kurt Harriman" <kharriman(at)greenplum(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: BufFileWrite across MAX_PHYSICAL_FILESIZE boundary
Date: 2007-05-07 20:53:12
Message-ID: 463F91B8.8060806@greenplum.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Just noticed buffile.c:292 doesn't look quite right where
BufFileDumpBuffer calls FileWrite:
bytestowrite = FileWrite(thisfile, file->buffer, bytestowrite);
It looks as though it would write the same data each time the
loop is iterated. Would this be better?
bytestowrite = FileWrite(thisfile, file->buffer + wpos, bytestowrite);

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-05-07 21:16:15 Behavior of GENERATED columns per SQL2003
Previous Message Joshua D. Drake 2007-05-07 19:52:44 Re: Re: [COMMITTERS] psqlodbc - psqlodbc: Put Autotools-generated files into subdirectory