Re: Re: IDENTITY/GENERATED v36 Re: [PATCHES] Final version of IDENTITY/GENERATED patch

From: Zoltan Boszormenyi <zb(at)cybertec(dot)at>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: IDENTITY/GENERATED v36 Re: [PATCHES] Final version of IDENTITY/GENERATED patch
Date: 2007-04-16 20:54:45
Message-ID: 4623E295.4050702@cybertec.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan írta:
> Florian G. Pflug wrote:
>>>>>
>>>>> bison -y -d gram.y
>>>>> conflicts: 2 shift/reduce
>>
>> I'ts been quite a time since I last used bison, but as far as I
>> remember, you can tell it to write a rather details log about
>> it's analysis of the grammar. That log should include more
>> detailed information about those conflicts - maybe that helps
>> to figure out their exact cause, and to find a workaround.
>>
>
> You can almost always get rid of shift/reduce conflicts by unwinding
> some of the productions - resist the temptation to factor the grammar.
> The effect of this is to eliminate places where the parser has to
> decide between shifting and reducing. (This is why, for example,
> almost all the "drop foo if exists" variants require separate
> productions rather than using opt_if_exists.)
>
> cheers
>
> andrew

Thanks. This idea solved one of the two shift/reduce conflicts.
But the other one can only be solved if I put GENERATED
into the reserved_keyword set. But the standard spec says
it's unreserved. Now what should I do with it?

Best regards,
Zoltán

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
>

--
----------------------------------
Zoltán Böszörményi
Cybertec Geschwinde & Schönig GmbH
http://www.postgresql.at/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Browne 2007-04-16 21:32:07 Re: Hacking on PostgreSQL via GIT
Previous Message Florian G. Pflug 2007-04-16 20:16:44 Re: Hacking on PostgreSQL via GIT

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2007-04-16 21:01:14 Re: scrollable cursor support without MOVE statement
Previous Message Magnus Hagander 2007-04-16 20:16:42 Re: patch to suppress psql timing output in quiet mode