Re: build/install xml2 when configured with libxml

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: build/install xml2 when configured with libxml
Date: 2007-04-14 03:53:05
Message-ID: 46205021.1030504@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian wrote:
> Andrew Dunstan wrote:
>
>> Peter Eisentraut wrote:
>>
>>>> And if it is, then you have several options:
>>>> . don't configure with libxml, or
>>>> . don't build contrib modules from the contrib Makefile (use the
>>>> individual module Makefiles instead), or
>>>> . change the xml2 Makefile
>>>>
>>>>
>>> Any of these could be worth considering, but it needs to be thought
>>> through first.
>>>
>>>
>>>
>> Well, I'm happy to receive suggestions.
>>
>
> Andrew has enabled /contrib/xml2 builds.
>
>

The attached patch adds a test for libxslt/xslt.h and only builds
contrib/xml2 if it's found, which I think should handle Peter's
objection, as well as unbreak the buildfarm. (The patch is large because
cvs diff seems to have behaved a bit oddly with the configure script -
but otherwise it's fairly minimal).

cheers

andrew

Attachment Content-Type Size
xml2.patch text/x-patch 25.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-04-14 05:04:37 Re: build/install xml2 when configured with libxml
Previous Message Alvaro Herrera 2007-04-13 23:24:09 Re: [HACKERS] choose_bitmap_and again (was Re: Strangely Variable Query Performance)

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-04-14 05:04:37 Re: build/install xml2 when configured with libxml
Previous Message Alvaro Herrera 2007-04-13 23:24:09 Re: [HACKERS] choose_bitmap_and again (was Re: Strangely Variable Query Performance)