Re: conflicting gettimeofday with MinGW

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Zeugswetter Andreas ADI SD <ZeugswetterA(at)spardat(dot)at>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: conflicting gettimeofday with MinGW
Date: 2007-04-13 14:03:44
Message-ID: 461F8DC0.7040804@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander wrote:
> On Wed, Apr 11, 2007 at 06:17:19PM +0200, Zeugswetter Andreas ADI SD wrote:
>
>>>> That page is ages out of date. The intended sync is
>>>>
>>> apparently broken.
>>>
>>>> The current download area is on sourceforge
>>>> http://sf.net/project/showfiles.php?group_id=2435
>>>>
>>>>
>>>>
>>> *sigh*
>>>
>>> And what is in 3.12, which is apparently the current version?
>>>
>> Sorry that was implied. sys/time.h did not change between 3.10 and 3.12.
>> There is no #define to remove the declaration.
>>
>> In cvs the file is marked as dead and gives a reference to cygwin's
>> w32api.
>> Maybe the answer is to simply note that the mingw-runtime binary from
>> sourceforge above 3.9 has a broken sys/time.h (it is not the file from
>> cygwin but the dead one from cvs).
>>
>
> I think that soudns reasonable. Something for the mingw FAQ. Care to
> provide bruce with a patch?
>
>

No, that means that we can't build with currently released Mingw, AIUI.
I think the solution is probably to rename our replacement gettimeofday
and add a #define to translate the calls. That's pretty much what we've
done in other cases, and has seemed to be a more robust strategy than
supplying replacements for standard library routines with routines of
the same name.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2007-04-13 14:33:18 Re: Group Commit
Previous Message Zeugswetter Andreas ADI SD 2007-04-13 13:40:31 Re: [PATCHES] Reviewers Guide to Deferred Transactions/Transaction Guarantee