Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Full page writes improvement, code update

From: Koichi Suzuki <suzuki(dot)koichi(at)oss(dot)ntt(dot)co(dot)jp>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Full page writes improvement, code update
Date: 2007-04-10 07:23:51
Message-ID: 461B3B87.2030708@oss.ntt.co.jp (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-hackerspgsql-patches
Hi,

Here're two patches for

1) lesslog_core.patch, patch for core, to set a mark to the log record 
to be removed in archiving,

2) lesslog_contrib.patch, patch for contrib/lesslog, pg_compresslog and 
pg_decompresslog,

respectively, as asked.  I hope they work.

Regards;

Simon Riggs wrote:
> On Tue, 2007-04-03 at 19:45 +0900, Koichi Suzuki wrote:
>> Bruce Momjian wrote:
>>> Your patch has been added to the PostgreSQL unapplied patches list at:
>>>
>>> 	http://momjian.postgresql.org/cgi-bin/pgpatches
>> Thank you very much for including.   Attached is an update of the patch 
>> according to Simon Riggs's comment about GUC name.
> 
> The patch comes with its own "install kit", which is great to review
> (many thanks), but hard to determine where you think code should go when
> committed.
> 
> My guess based on your patch
> - the patch gets applied to core :-)
> - pg_compresslog *and* pg_decompresslog go to a contrib directory called
> contrib/lesslog?
> 
> Can you please produce a combined patch that does all of the above, plus
> edits the contrib Makefile to add all of those, as well as editing the
> README so it doesn't mention the patch, just the contrib executables?
> 
> The patch looks correct to me now. I haven't tested it yet, but will be
> doing so in the last week of April, which is when I'll be doing docs for
> this and other stuff, since time is pressing now.
> 


-- 
Koichi Suzuki

Attachment: lesslog_core.patch
Description: text/plain (6.8 KB)
Attachment: lesslog_contrib.patch
Description: text/plain (46.7 KB)

In response to

Responses

pgsql-hackers by date

Next:From: NikhilSDate: 2007-04-10 08:20:16
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support
Previous:From: Nikolay SamokhvalovDate: 2007-04-10 07:10:15
Subject: Re: "select ('{}'::text[])[1]" returns NULL -- is it correct?

pgsql-patches by date

Next:From: Gregory StarkDate: 2007-04-10 08:05:39
Subject: Re: non-recursive WITH clause support
Previous:From: ITAGAKI TakahiroDate: 2007-04-10 02:02:00
Subject: Re: [PATCHES] Fix mdsync never-ending loop problem

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group