Re: Current enums patch

From: Tom Dunstan <pgsql(at)tomd(dot)cc>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Current enums patch
Date: 2007-04-02 19:32:34
Message-ID: 46115A52.7010702@tomd.cc
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> But probably making them act like identifiers is not a good idea,
> because I doubt we want automatic downcasing in enum_in. People
> wouldn't be happy if they had to write WHERE color = '"Red"' or
> something like that to get at a mixed-case enum label.

Ah, that's what you had in mind. Yeah, that's a bit verbose.

> Let's
> just throw the error instead. (I agree that enum_in can just fail
> with "no such label", but CREATE TYPE ought to give a specific
> error about it.)

Agreed.

Andrew, you said you had a mostly-working patch already?

Cheers

Tom

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-04-02 19:33:18 Re: Blocked post
Previous Message Tom Lane 2007-04-02 19:32:15 Re: Blocked post