Re: Empty %files file debugsourcefiles.list

From: Marcin Cieslak <saper(at)saper(dot)info>
To: Devrim Gündüz <devrim(at)gunduz(dot)org>
Cc: pgsql-pkg-yum(at)lists(dot)postgresql(dot)org
Subject: Re: Empty %files file debugsourcefiles.list
Date: 2025-04-24 09:59:51
Message-ID: 45o54n8q-5o31-rnnn-p2n6-rs6rn5oo1nnp@fncre.vasb
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-pkg-yum

On Thu, 24 Apr 2025, Devrim Gündüz wrote:

> Hi,
>
> On Wed, 2025-04-23 at 17:14 +0000, Marcin Cieslak wrote:
>>>
>>> Thanks for the analysis -- but please note that we don't have this
>>> problem on the buildfarm instances which have the same symlinks.
>>
>> Building from this directory does not work:
>>
>> pgrpms/rpm/redhat/17/postgresql-17/F-41
>>
>> Building from this one works:
>>
>> pgrpms/rpm/redhat/main/non-common/postgresql-17/F-41
>>
>> I haven't read the "scripts" directory carefully yet, but it looks
>> like the packagebuild.sh uses the "non-common" directories to build.
>
> Both of them are symlinks actually -- though the former is a symlink to
> a symlink.

From here it looks like this:

$ find -P 17 17/postgresql-17 17/postgresql-17/F-42 main main/non-common main/non-common/postgresql-17 main/non-common/postgresql-17/F-42 -ls -prune
16926170 8 drwxr-xr-x 152 saper saper 4096 Apr 18 21:59 17
670798 0 drwxr-xr-x 2 saper saper 94 Apr 18 21:59 17/postgresql-17
670804 0 lrwxrwxrwx 1 saper saper 40 Apr 18 21:59 17/postgresql-17/F-42 -> ../../main/non-common/postgresql-17/F-42
26306366 0 drwxr-xr-x 6 saper saper 68 Apr 18 21:59 main
676643 12 drwxr-xr-x 166 saper saper 8192 Apr 18 21:59 main/non-common
678059 0 drwxr-xr-x 10 saper saper 106 Apr 18 21:59 main/non-common/postgresql-17
16933863 4 drwxr-xr-x 3 saper saper 4096 Apr 21 17:03 main/non-common/postgresql-17/F-42

Most of the *files* in main/non-common/postgresql-17/F-42 are symbolic links, but the source files whose
paths will be embedded in the DWARF information are located in a normal tree of directories:

$ find -P F-42/postgresql17-17.4-build F-42/postgresql17-17.4-build/postgresql-17.4 F-42/postgresql17-17.4-build/postgresql-17.4/src -prune -ls
1099584 0 drwxr-xr-x 4 saper saper 46 Apr 24 09:42 F-42/postgresql17-17.4-build
17946944 4 drwxr-xr-x 6 saper saper 4096 Apr 24 09:43 F-42/postgresql17-17.4-build/postgresql-17.4
1206330 4 drwxr-xr-x 16 saper saper 4096 Apr 24 09:43 F-42/postgresql17-17.4-build/postgresql-17.4/src

The solution could be to move the build tree outside of this symlink maze and things should be fine (if we need those 1[3-8] trees at all).

Sorry for being a pain - this was quite a showstopper for me

Marcin

In response to

Browse pgsql-pkg-yum by date

  From Date Subject
Next Message Marcin Cieslak 2025-04-24 11:25:24 prep18 target
Previous Message Devrim Gündüz 2025-04-24 07:52:57 Re: Empty %files file debugsourcefiles.list