| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | michael(dot)banck(at)credativ(dot)de, pgsql-hackers(at)postgresql(dot)org, sfrost(at)snowman(dot)net |
| Subject: | Re: [Patch] Make pg_checksums skip foreign tablespace directories |
| Date: | 2020-02-25 00:44:04 |
| Message-ID: | 45f6d9c5-ad73-b20b-dd03-f9c3770c54b9@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Michael,
On 2/24/20 7:26 AM, Michael Paquier wrote:
> On Sun, Feb 23, 2020 at 04:08:58PM +0900, Michael Paquier wrote:
>> Good idea. Let's do things as you suggest.
>
> Applied and back-patched this one down to 11.
FWIW, we took a slightly narrower approach to this issue in the
pgBackRest patch (attached).
I don't have an issue with the prefix approach since it works and the
Postgres project is very likely to catch it if there is a change in
behavior.
For third-party projects, though, it might pay to be more conservative
in case the behavior changes in the future, i.e.
pg_internal.init[something] (but not pg_internal\.init[0-9]+) becomes valid.
Regards,
--
-David
david(at)pgmasters(dot)net
| Attachment | Content-Type | Size |
|---|---|---|
| pginternalinit-pid.patch | text/plain | 8.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2020-02-25 00:54:53 | Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index. |
| Previous Message | Andres Freund | 2020-02-24 23:29:28 | Re: Memory-Bounded Hash Aggregation |