| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Dave Cramer <davecramer(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PL/R regression on windows, but not linux with master. |
| Date: | 2021-04-11 15:01:54 |
| Message-ID: | 45e1c9cc-ff7d-dbe9-19bb-c4139773e2f8@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/11/21 10:13 AM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>> Well, plr.h does this:
>>>
>>> #define WARNING 19
>>> #define ERROR 20
>
>> The coding pattern in plr.h looks quite breakable.
Meh -- that code has gone 18+ years before breaking.
> Indeed. elog.h already provides a "PGERROR" macro to use for restoring
> the value of ERROR. We have not heard of a need to do anything special
> for WARNING though --- maybe that's R-specific?
R also defines WARNING in its headers. If I remember correctly there are (or at
least were, it *has* been 18+ years since I looked at this particular thing)
some odd differences in the R headers under Windows and Linux.
In any case we would be happy to use "PGERROR".
Would an equivalent "PGWARNING" be something we are open to adding and
back-patching?
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2021-04-11 15:09:05 | Re: Avoid unnecessary table open/close for TRUNCATE foo, foo, foo; kind of commands |
| Previous Message | Rémi Lapeyre | 2021-04-11 14:35:12 | Re: Add header support to text format and matching feature |