| From: | "David E(dot) Wheeler" <david(at)justatheory(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Mankirat Singh <mankiratsingh1315(at)gmail(dot)com> |
| Subject: | Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats() |
| Date: | 2025-10-17 21:41:27 |
| Message-ID: | 45D16ED3-8561-4287-8D39-E0345D4B46F6@justatheory.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Oct 17, 2025, at 16:19, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I agree. I don't think the buildfarm should consider git tags at all
> in this behavior. One reason is that our release process dictates
> applying tags at very specific times that aren't necessarily relevant
> to deciding that an ABI break is or is not okay. I think we want
> moving the baseline to be a considered reaction to an observed ABI
> report, and not an action that is automatic according to some other
> process.
Okay, so the rule is:
* If there is no .abi-compliance-history file, baseline from the latest tag
* Otherwise, baseline from the first SHA to appear in the file
Easy peasy.
D
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-10-17 21:51:44 | Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats() |
| Previous Message | Tom Lane | 2025-10-17 21:14:02 | Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master |