| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Robert Treat <rob(at)xzilla(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DOC: fixes multiple errors in alter table doc |
| Date: | 2026-03-09 09:50:01 |
| Message-ID: | 45C2A2AE-DBAD-4996-AF80-0F948A3EA460@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Mar 9, 2026, at 17:43, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Fri, Mar 6, 2026 at 4:53 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>> PFA v6.
>
> Thanks for updating the patch!
>
>> The two test cases on table level “IF EXISTS” are removed. So, now the patch adds totally 4 test cases: 2 for omitting COLUMN, 2 for combinations of column level “IF [NOT] EXISTS” and omitting COUMN.
>
> The latest patch doesn't seem to include the combination of column-level
> IF NOT EXISTS for ADD COLUMN and omitting COLUMN.
>
>
> Based on your patch, I updated the regression tests as follows and
> pushed the changes:
>
> +ALTER FOREIGN TABLE ft1 ADD c11 integer; -- omit COLUMN
> +ALTER FOREIGN TABLE ft1 DROP c11; -- omit COLUMN
>
> I moved the ALTER FOREIGN TABLE DROP test into the section that lists the other
> existing ALTER FOREIGN TABLE DROP COLUMN tests.
>
> Regarding table-level IF EXISTS tests, it seemed to me that most
> ALTER FOREIGN TABLE ADD/DROP variants should also be tested there,
> following the existing structure in foreign_data.sql. So I added some
> additional cases, for example ALTER FOREIGN TABLE IF EXISTS ADD COLUMN IF
> NOT EXISTS.
>
> Regards,
>
> --
> Fujii Masao
Thank you so much for taking care of that.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Boris Mironov | 2026-03-09 09:57:57 | Re: Idea to enhance pgbench by more modes to generate data (multi-TXNs, UNNEST, COPY BINARY) |
| Previous Message | Fujii Masao | 2026-03-09 09:43:39 | Re: DOC: fixes multiple errors in alter table doc |